Add dry-validation contract support #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks ok to me. Should probably fix up the code climate stuff though. |
pkuczynski
requested changes
Jul 17, 2019
|
@pkuczynski @rdubya which of these do you want me to address? https://codeclimate.com/github/railsconfig/config/pull/238# For the |
Some minor updates
pkuczynski
reviewed
Jul 18, 2019
| @@ -23,7 +24,8 @@ module Config | |||
| knockout_prefix: nil, | |||
| merge_nil_values: true, | |||
| overwrite_arrays: true, | |||
| merge_hash_arrays: false | |||
| merge_hash_arrays: false, | |||
| validation_contract: nil | |||
There was a problem hiding this comment.
I am still wondering if we should call it validation_contract or simply contract. @pyromaniac @rdubya @supremebeing7 what you think?
There was a problem hiding this comment.
I'm in favor of being explicit - validation_contract
|
@ryanwjackson would 67624d4 makes sense to you? |
|
@pkuczynski Makes sense. Just fixed the keyword passing. |
|
Looks good to me. Waiting for tests to pass and I will merge it in! |
pkuczynski
previously approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #237
@pkuczynski Please let me know if there is anything missing or you would like changed.