Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent documentation for ENV prefix and default value in generator #246

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Fix inconsistent documentation for ENV prefix and default value in generator #246

merged 3 commits into from
Aug 6, 2019

Conversation

pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Aug 6, 2019 •
edited
Loading

Fixes #162

@pkuczynski pkuczynski mentioned this pull request Aug 6, 2019
Closed
@pkuczynski pkuczynski self-assigned this Aug 6, 2019
@pkuczynski pkuczynski added this to the 2.0.1 milestone Aug 6, 2019
@smoyte
Copy link

smoyte commented Aug 6, 2019

LGTM, thanks!

@pkuczynski
Copy link
Member Author

Your welcome! Sorry for the late reply!

@pkuczynski pkuczynski merged commit 2a714d2 into master Aug 6, 2019
@pkuczynski pkuczynski deleted the env-prefix branch August 6, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyromaniac pyromaniac Awaiting requested review from pyromaniac

@rdubya rdubya Awaiting requested review from rdubya

@supremebeing7 supremebeing7 Awaiting requested review from supremebeing7

Assignees

@pkuczynski pkuczynski

Labels
documentation
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Inconsistent documentation for ENV prefix
2 participants
@pkuczynski @smoyte