Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe check for 'window' to support server rendering #287

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add safe check for 'window' to support server rendering #287

merged 1 commit into from
Oct 19, 2021

Conversation

AlexMeah
Copy link
Contributor

Without this check an exception is raised when server rendering. This is masked by evaljs("var window = this;", {force: true}) is spec_helper.rb

@le0pard
Copy link
Member

le0pard commented Oct 19, 2021

Looks ok. Your move @bogdan

@le0pard le0pard requested a review from bogdan October 19, 2021 10:44
@bogdan bogdan merged commit 877b89c into railsware:master Oct 19, 2021
@AlexMeah AlexMeah deleted the ssr branch October 19, 2021 11:50
@AlexMeah
Copy link
Contributor Author

AlexMeah commented Nov 1, 2021

@bogdan Please can you do a new release

@bogdan
Copy link
Collaborator

bogdan commented Nov 1, 2021

Released 2.1.2 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan bogdan Awaiting requested review from bogdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexMeah @le0pard @bogdan