Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

npm run package should build for all the platforms #57

Closed
vlad-shatskyi opened this issue Sep 7, 2015 · 5 comments
Closed

npm run package should build for all the platforms #57

vlad-shatskyi opened this issue Sep 7, 2015 · 5 comments
Labels

Comments

@vlad-shatskyi
Copy link
Contributor

Currently the package script

rm -rf '/Applications/Black Screen.app'; electron-packager . 'Black Screen' --platform=darwin --arch=x64 --version='0.30.0' --out='/Applications' --icon='./icon.icns'

is very platform dependent.

Perhaps, it's worth looking into how Atom or other Electron projects are being packaged.

@G07cha
Copy link
Contributor

G07cha commented Sep 7, 2015

We can use gulp-if for this or just create separate scripts for Unix and non-Unix system

@vlad-shatskyi
Copy link
Contributor Author

https://github.com/maxogden/electron-packager supports builds for different platforms out of the box. Maybe there are better tools.

@G07cha
Copy link
Contributor

G07cha commented Sep 7, 2015

For production build we can use 'all' for platform and arch options, and for development provide specific scripts.

@vlad-shatskyi
Copy link
Contributor Author

Let's try that.

@joshwiens
Copy link

@ShockOne @G07cha - This task fits well with #63 and much like the CI & CD, I am happy to pick this one up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants