Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom native review module with expo-store-review #6268

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

maxbbb
Copy link

@maxbbb maxbbb commented Nov 16, 2024

Fixes APP-2038

What changed (plus any additional context for devs)

Fixes the app not being able to receive touches after the SKStoreReviewController was shown on iOS.

The app would not be able to receive any touches until force closed regardless of if the user selected "Not Now" or rated the app once the SKStoreReviewController was shown.

expo-store-review was added to replace custom native module implementation, but that did not fix the issue.
The addition of expo-store-review was kept regardless due to the custom native module implementations being 5 years old and including some method swizzling and arbitrary timeouts to get around issues that no longer exist.

The issue was related to this extension in the Extensions.swift file

extension UIView { 
  open override var canBecomeFirstResponder: Bool {
      return true
  }
}

This code was added in a 5 year old PR (#509) for improving performance of a native list component that is no longer used, so it should be safe to remove.

This issue CocoaDebug/CocoaDebug/issues/143 has more information on why this happens

Screen recordings / screenshots

RPReplay_Final1731728558.MP4

What to test

  • Go to settings
  • Click "Review Rainbow"
  • Click "Yes"
  • Click "Not Now", and the app should not freeze.

Copy link

linear bot commented Nov 16, 2024

@maxbbb maxbbb requested a review from walmat November 16, 2024 03:54
Copy link

socket-security bot commented Nov 16, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/expo-store-review@7.0.2 None 0 29.9 kB brentvatne

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant