Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML in Footnotes #450

Closed
Cameron-Cn opened this issue Jun 9, 2019 · 6 comments
Closed

HTML in Footnotes #450

Cameron-Cn opened this issue Jun 9, 2019 · 6 comments
Labels
third party Not related to the repository, it must be handled by a third party instead Type: Bug Report that has been identified / verified as an issue requiring resolution

Comments

@Cameron-Cn
Copy link

Cameron-Cn commented Jun 9, 2019

(Edit: A mighty thanks for the effort here!)
Sorry if this is a duplicate or the wrong github!

It would appear that the footnotes issue remains--displaying HTML code in the footnote itself.

Lorem Ipsum dolor.[^1]
----
 [^1]<p>The footnote.&#160;<a href="#fnref1:1" rev="footnote" 
class="footnote-backref">&#8617;</a></p>

I think this is the bug in question:
erusev/parsedown-extra#118
Am I right in understanding this is an upstream issue, and we have to wait for a fix?

Or is there anything a PHP newbie like myself could be helpful with in regards to the footnote issue?

@bennothommo bennothommo added Status: On Hold Put on hold for now but will be worked on again in the future third party Not related to the repository, it must be handled by a third party instead Type: Bug Report that has been identified / verified as an issue requiring resolution labels Jun 10, 2019
@bennothommo
Copy link
Contributor

@Cameron-Cn You are correct - it's currently an upstream issue with the ParsedownExtra library. They have released a beta version with this issue fixed, but we can't use that yet. We'd either need to wait for the fix to be made stable, or apply the fix ourselves on a fork.

@Cameron-Cn
Copy link
Author

Ah, I'll go see if the discussion over there has any hints about it.
There's a messy patch, but I'm not confident enough to implement a beta myself!

Thank you!

@bennothommo bennothommo added Status: Blocked Blocked from progressing by something (usually another related issue / PR) and removed Status: On Hold Put on hold for now but will be worked on again in the future labels Jul 28, 2019
@aurelien-roy
Copy link

0.8.1 is now stable and includes a fix for erusev/parsedown-extra#118

@LukeTowers
Copy link
Contributor

@bennothommo are we pulling in that version on composer update or do we need to update our dependencies?

@bennothommo
Copy link
Contributor

@LukeTowers yep, I believe the library will bring in the new version through its Composer requirements.

@bennothommo bennothommo removed the Status: Blocked Blocked from progressing by something (usually another related issue / PR) label Jan 15, 2020
@bennothommo
Copy link
Contributor

This should be fixed by running a composer update in your site to retrieve the latest version of the Parsedown Extra library. The next build of October will include that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third party Not related to the repository, it must be handled by a third party instead Type: Bug Report that has been identified / verified as an issue requiring resolution
Projects
None yet
Development

No branches or pull requests

4 participants