New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user define email and password in the env #1

Open

rajathans opened this issue Mar 18, 2018 · 0 comments

Labels

enhancement good first issue

Owner

rajathans commented Mar 18, 2018 •

edited

Loading

We can pick the email and password of the Shiprocket user from env, and remove it from the Client constructor.

$client = new Client(['email' => '',
                'password' => '',
                'use_sandbox' => 0]);

$orders = $client->getOrders();

rajathans added the enhancement label

rajathans added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment