Merge pull request #228 from devenv/only_on_new_tasks

[notifications] only_on_new_tasks option
GothenburgBitFactory · Jul 28, 2015 · 89ef3d7 · 89ef3d7
2 parents 90c81db + b4a67eb
commit 89ef3d7
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/bugwarrior/db.py b/bugwarrior/db.py
@@ -315,7 +315,7 @@ def _bool_option(section, option, default):
     # Before running CRUD operations, call the pre_import hook(s).
     run_hooks(conf, 'pre_import')
 
-    notify = _bool_option('notifications', 'notifications', 'False') and not dry_run
+    notify = _bool_option('notifications', 'notifications', False) and not dry_run
 
     tw = TaskWarriorShellout(
         config_filename=get_taskrc_path(conf, main_section),
@@ -444,17 +444,19 @@ def _bool_option(section, option, default):
 
     # Send notifications
     if notify:
-        send_notification(
-            dict(
-                description="New: %d, Changed: %d, Completed: %d" % (
-                    len(issue_updates['new']),
-                    len(issue_updates['changed']),
-                    len(issue_updates['closed'])
-                )
-            ),
-            'bw_finished',
-            conf,
-        )
+        only_on_new_tasks = _bool_option('notifications', 'only_on_new_tasks', False)
+        if not only_on_new_tasks or len(issue_updates['new']) + len(issue_updates['changed']) + len(issue_updates['closed']) > 0:
+            send_notification(
+                dict(
+                    description="New: %d, Changed: %d, Completed: %d" % (
+                        len(issue_updates['new']),
+                        len(issue_updates['changed']),
+                        len(issue_updates['closed'])
+                    )
+                ),
+                'bw_finished',
+                conf,
+            )
 
 
 def build_key_list(targets):

diff --git a/bugwarrior/docs/common_configuration.rst b/bugwarrior/docs/common_configuration.rst
@@ -158,6 +158,7 @@ by ``bugwarrior-pull``::
   backend = growlnotify
   finished_querying_sticky = False
   task_crud_sticky = True
+  only_on_new_tasks = True
 
 Backend options:
 

diff --git a/bugwarrior/docs/configuration.rst b/bugwarrior/docs/configuration.rst
@@ -73,6 +73,7 @@ Example Configuration
     # backend = growlnotify
     # finished_querying_sticky = False
     # task_crud_sticky = True
+    # only_on_new_tasks = True
     
     
     # This is a github example.  It says, "scrape every issue from every repository