Mount COS_PERSISTENT in cos-deploy #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudlers
force-pushed
the
use_cos_persistent_in_cos_deploy
branch
from
35b9efb to
ee04c0a
Compare
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudlers
force-pushed
the
use_cos_persistent_in_cos_deploy
branch
from
ee04c0a to
701f047
Compare
Itxaka
reviewed
Aug 12, 2021
Itxaka
reviewed
Aug 12, 2021
| @@ -89,6 +93,8 @@ mount_image() { | |||
| mount_state | |||
| fi | |||
|
|
|||
| is_mounted /usr/local || mount ${PERSISTENT} /usr/local | |||
|
|
|||
There was a problem hiding this comment.
should we umount this on clean2 just in case?
There was a problem hiding this comment.
good question 🤔 It should not do any harm... on the other hand it might be helpful for the hooks if they have to do something in the COS_PERSISTENT partition
|
manually tested and it works as expected where the master script failed. nice! |
Itxaka
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #510
Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com