-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Increase timeout on test raw #566
Conversation
f15836a
to
c7b1655
Compare
I'd rather see such constants be defined in a central place instead of being embedded in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good here
This is part of the test stuff, Im not sure we need a central place for the test config??? I can create one and move it there but....I dont know if it would be useful... |
c7b1655
to
4e816b7
Compare
I'd say we are fine with the defaults already defined in the SUT, this is just overriding for the special case |
mmh still fails also with the timeout bumped:
Maybe a bug is hiding there? |
I think its just a timeout, if you check the serial log it shows that the machine wasnt up when we recovered it, so it was slow to boot. Plus the usual grub fallback also doesnt help (needs to fallback 3??4?? times until it launches the recovery) EDIT: yep, this time it was on the |
Currently the github runners performance is not stable enough to let the auto retry on the test framework to work as expected in the given time (180s) This patch bumps the timeout to 300 seconds instead which should be more than enough for the VM to come up. Signed-off-by: Itxaka <igarcia@suse.com>
4e816b7
to
ea538b9
Compare
Currently the github runners performance is not stable enough to let the
auto retry on the test framework to work as expected in the given time
(180s)
This patch bumps the timeout to 300 seconds instead which should be more
than enough for the VM to come up.
Signed-off-by: Itxaka igarcia@suse.com