ci: use time param for reboot #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we had the reboot function on SUT with a hardcoded timeout which was hitting its limits on the raw disk test This modifies the reboot function so it acceps a timeout and passes it to the EventuallyConnects function Signed-off-by: Itxaka <igarcia@suse.com>
|
According to the serial logs I checked a while ago on some failed tests I saw that first boot took around 250 seconds and it was failing due to a timeout on reboot. So increasing the reboot time might definitely help to fix the issue, even though more 180s for a single reboot without having to install anything at boot time is close to the unacceptable area, but we can analyze that later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we had the reboot function on SUT with a hardcoded timeout
which was hitting its limits on the raw disk test
This modifies the reboot function so it acceps a timeout and passes it
to the EventuallyConnects function
Signed-off-by: Itxaka igarcia@suse.com