Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cloud instances #649

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Sep 15, 2021

No description provided.

Itxaka added 3 commits September 15, 2021 15:10
Also some more flair to messages

Signed-off-by: Itxaka <igarcia@suse.com>
Also more info to instances.txt to be able to track what happened

Signed-off-by: Itxaka <igarcia@suse.com>
Removed the manual dispatch of the job and the hours variable to avoid
external triggers deleting stuff

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka requested a review from mudler September 15, 2021 13:36
@Itxaka
Copy link
Contributor Author

Itxaka commented Sep 15, 2021

This has been tested with 2 of my instances and it removed them correctly. Also it left the one in the exclude list alone.

Signed-off-by: Itxaka <igarcia@suse.com>
@mudler
Copy link
Contributor

mudler commented Sep 15, 2021

No sense to wait for CI tests here 👍 let's just merge it @Itxaka ?

@Itxaka
Copy link
Contributor Author

Itxaka commented Sep 15, 2021

one sec @mudler !!!

only run it if the CI env is set and exit with a message if the CI env
is NOT set and the DO_CLEANUP is, as we have our exclude list on the
workflow so if someone runs this script locally it will terminate the
current instances, as it will have an empty EXCLUDE_LIST

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka
Copy link
Contributor Author

Itxaka commented Sep 15, 2021

there we go @mudler as small safeguard against running the script locally!

@Itxaka Itxaka merged commit bd5f966 into rancher:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants