Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint to latest and (8.39.0) and fix vue linting errors #5298

Closed
Tracked by #4580
rak-phillip opened this issue Aug 4, 2023 · 0 comments · Fixed by #5610
Closed
Tracked by #4580

Update eslint to latest and (8.39.0) and fix vue linting errors #5298

rak-phillip opened this issue Aug 4, 2023 · 0 comments · Fixed by #5610
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Aug 4, 2023 •
edited
Loading

#5287 downgraded eslint from 8.39.0 to 7.32.0. We should be able to revert back to 8.39.0, but this will require some in-depth refactoring for some of our Vue Components. Rather than tackling this in the nuxt removal PR, it will be easier to reason about the changes in a standalone PR.
@rak-phillip rak-phillip mentioned this issue Aug 4, 2023
Closed
15 tasks
@gaktive gaktive added the kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API label Aug 8, 2023
@rak-phillip rak-phillip mentioned this issue Aug 15, 2023
Merged
@rak-phillip rak-phillip mentioned this issue Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump eslint to 8.39.0 rak-phillip/rancher-desktop
2 participants
@rak-phillip @gaktive