Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers Dashboard Does Not Filter by State #5893

Closed
Tracked by #5841
rak-phillip opened this issue Oct 31, 2023 · 3 comments · Fixed by #6002
Closed
Tracked by #5841

Containers Dashboard Does Not Filter by State #5893

rak-phillip opened this issue Oct 31, 2023 · 3 comments · Fixed by #6002
Assignees
Milestone

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Oct 31, 2023

The filter on the Containers table is not functioning as expected. The displayed results are inaccurate when attempting to filter containers based on their status or image name.

Steps to reproduce

  1. Start new containers
    1. Start a Docker container: docker run -d -p 5500:80 --restart=always nginx
    2. Create a Kubernetes deployment: kubectl create deployment nginx-test --image=nginx:stable
    3. Create a Kubernetes service: kubectl create service clusterip nginx-test --tcp=5000:80
  2. Filter the Containers table
    1. Navigate to Containers
    2. In the filter input, enter "running" to filter by the container's status
    3. In a separate attempt, enter "nginx" to filter by containers with the nginx image

Expected behavior

  • When filtering by "running," the Containers list should only display running containers

Actual behavior

  • When filtering by "running," the Containers list displays "There are no rows which match your search query" instead of showing running containers
@scures
Copy link
Contributor

scures commented Nov 20, 2023

Hey Phill,

When filtering by "running," the Containers list should only display running containers

This is now fixed as part of #6002

When filtering by "nginx," the Containers list should only display containers with the nginx image

Given the generic nature of the search field (unless we want to go into advanced filters which I'm not sure we support) I think the current behavior is ok. It will filter for both image & container name (this is important to be able to find named containers)

@jandubois
Copy link
Member

Given the generic nature of the search field (unless we want to go into advanced filters which I'm not sure we support) I think the current behavior is ok.

I agree. At first it was surprising to me that the filter expression is applied to all columns and not just the name, and I can conceive situations where this might show more containers than you want, but I certainly like the simplicity of it.

Let's keep the simple filtering across all columns as the only option for now.

@rak-phillip rak-phillip changed the title Containers Dashboard Does Not Filter by State and Image Containers Dashboard Does Not Filter by State Nov 20, 2023
@rak-phillip
Copy link
Contributor Author

rak-phillip commented Nov 20, 2023

When filtering by "nginx," the Containers list should only display containers with the nginx image

It looks like the existing filter behaves as expected by matching name/image to the provided string. I've removed the criteria related to filtering the image by name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants