-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or replace Nuxt reference and logic for Vue3 migration #10491
Comments
What's the issue you're seeing with |
@cnotv here's the current progress codyrancher#3. I'll continue on the list. |
In Vue 3 you cannot import anymore Vue from the library, there's just the function |
@codyrancher found another case which I forgot: https://github.com/rancher/dashboard/blob/master/shell/initialize/index.js#L165-L178 |
I'm adding other cases while crossing them because the app breaks, just in case we miss them. |
@cnotv I've opened a PR which takes care of each of the checked items on the list. For the remaining items:
|
Yeah it actually seems working without touch it, so far. |
Description
Some lingering code inherited form Nuxt is going to clash with the breaking changes from the Vue3 migrations.
These needs to be either corrected to match the syntax, removed if unnecessary or replaced with a new implementation.
Context
Given the deprecation of the emitters, all these cases have to be handled as they will break for sure:
$nuxt.$on
$nuxt.$off
$nuxt.$emit
Other breaking cases:
$nuxt.$nextTick
(docs)Vue.util.defineReactive
, used in more placesVue.__nuxt__fetch__mixin__
Can be removed in migration branchComponent = Vue.extend(Component);
(docs)Vue[installKey]
(lines)Can be removed in migration branchvueDirective.apply(Vue, arguments);
(line)Vue.config.$nuxt.$nuxt = true;
andVue.config().$nuxt = {};
(line)vueApp.config().$nuxt
(line)Seems can be left untouchednuxt.publicRuntimeConfig
, this is needed to start the app (line)Optional other cases which would be nice to get rid of:
$nuxt.$nuxt
$nuxt.$store
$nuxt.$route
$nuxt.$router
The text was updated successfully, but these errors were encountered: