Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $cookies global and related logic #11392

Open
cnotv opened this issue Jul 9, 2024 · 2 comments
Open

Replace $cookies global and related logic #11392

cnotv opened this issue Jul 9, 2024 · 2 comments
Labels
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented Jul 9, 2024

Description

From a removal attempt (#11272), the global $cookies and 2-way binding logic adopted are defined from the plugin cookie-universal-nuxt. This has been replaced with a more generic one cookie-universal #11321
As the logic creates several issues, replace with some more conventional patterns.
The main reason is the presence of too many states: cookies, global, and Vuex.

Occurrences are not so high:
https://github.com/search?q=%24cookies+repo%3Arancher%2Fdashboard&type=code&ref=advsearch

Screenshot 2024-07-01 at 17 26 43
@nwmac
Copy link
Member

nwmac commented Sep 27, 2024

@cnotv Can we push this to 2.11?

@cnotv cnotv modified the milestones: v2.10.0, v2.11.0 Sep 27, 2024
@cnotv
Copy link
Contributor Author

cnotv commented Sep 27, 2024

@cnotv Can we push this to 2.11?

Yes definitely. @rak-phillip has found a generic replacement that makes this change not strictly necessary. unless we want to change the logic around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants