Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-once cleanup gitjobs job #2926

Open
3 tasks
0xavi0 opened this issue Oct 2, 2024 · 1 comment
Open
3 tasks

Add run-once cleanup gitjobs job #2926

0xavi0 opened this issue Oct 2, 2024 · 1 comment

Comments

@0xavi0
Copy link
Contributor

0xavi0 commented Oct 2, 2024

After merging #2903 we need:

@0xavi0 0xavi0 added this to the v2.9.3 milestone Oct 2, 2024
@0xavi0 0xavi0 self-assigned this Oct 2, 2024
@0xavi0 0xavi0 added this to Fleet Oct 2, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Oct 2, 2024
@0xavi0 0xavi0 modified the milestones: v2.9.3, v2.10.0 Oct 2, 2024
@0xavi0 0xavi0 moved this from 🆕 New to Needs QA review in Fleet Oct 7, 2024
@0xavi0
Copy link
Contributor Author

0xavi0 commented Oct 7, 2024

Additional QA

Problem

We need to update the cleanup gitjobs job to delete all the jobs that are created by GitRepos and that are Finished.
We need to test that this is executed when updating Fleet from a previous version.

Solution

  • The job should run only once, after updating
  • The job should use the right ServiceAccount
  • The job should delete all the jobs that are relative to a GitRepo and that succeeded.

Testing

Start using Rancher 2.9.2

  • Apply a GitRepo that is successful, update the git repository, so Fleet creates a new job per each new commit. Repeat until you have a few jobs.
  • Update Fleet to 2.9.3
  • Check that all jobs that succeeded are deleted.
  • Check also that after the update Fleet creates a new job per each commit, but this time the job is deleted after it succeeds.

@0xavi0 0xavi0 moved this from Needs QA review to ✅ Done in Fleet Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant