Race condition occurring between finishing job and new incoming commit from Webhook #3067
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue:
With a webhook in place, if a commit is sent while the previous job is not finished the gitjob never changes status.
In the screenshot it can be seen how even when the replica number has been updated to 5, still the UI displays 2.
To reproduce
Observed behavior:
Expected behavior:
Logs:
Webhook Payload
{ "ref": "refs/heads/main", "before": "ded1afcfdd8f0c0b4bddb242e0c75b374e189224", "after": "21c9d870151b6da1bedc2681014c39cdf8129585", "repository": { "id": 836697933, "node_id": "R_kgDOMd7_TQ", "name": "webhook-github-test", "full_name": "fleetqa/webhook-github-test", "private": false, "owner": { "name": "fleetqa", "email": "166113384+fleetqa@users.noreply.github.com", "login": "fleetqa", "id": 166113384, "node_id": "U_kgDOCeawaA", "avatar_url": "https://avatars.githubusercontent.com/u/166113384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fleetqa", "html_url": "https://github.com/fleetqa", "followers_url": "https://api.github.com/users/fleetqa/followers", "following_url": "https://api.github.com/users/fleetqa/following{/other_user}", "gists_url": "https://api.github.com/users/fleetqa/gists{/gist_id}", "starred_url": "https://api.github.com/users/fleetqa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fleetqa/subscriptions", "organizations_url": "https://api.github.com/users/fleetqa/orgs", "repos_url": "https://api.github.com/users/fleetqa/repos", "events_url": "https://api.github.com/users/fleetqa/events{/privacy}", "received_events_url": "https://api.github.com/users/fleetqa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "html_url": "https://github.com/fleetqa/webhook-github-test", "description": null, "fork": false, "url": "https://github.com/fleetqa/webhook-github-test", "forks_url": "https://api.github.com/repos/fleetqa/webhook-github-test/forks", "keys_url": "https://api.github.com/repos/fleetqa/webhook-github-test/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/fleetqa/webhook-github-test/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/fleetqa/webhook-github-test/teams", "hooks_url": "https://api.github.com/repos/fleetqa/webhook-github-test/hooks", "issue_events_url": "https://api.github.com/repos/fleetqa/webhook-github-test/issues/events{/number}", "events_url": "https://api.github.com/repos/fleetqa/webhook-github-test/events", "assignees_url": "https://api.github.com/repos/fleetqa/webhook-github-test/assignees{/user}", "branches_url": "https://api.github.com/repos/fleetqa/webhook-github-test/branches{/branch}", "tags_url": "https://api.github.com/repos/fleetqa/webhook-github-test/tags", "blobs_url": "https://api.github.com/repos/fleetqa/webhook-github-test/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/fleetqa/webhook-github-test/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/fleetqa/webhook-github-test/git/refs{/sha}", "trees_url": "https://api.github.com/repos/fleetqa/webhook-github-test/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/fleetqa/webhook-github-test/statuses/{sha}", "languages_url": "https://api.github.com/repos/fleetqa/webhook-github-test/languages", "stargazers_url": "https://api.github.com/repos/fleetqa/webhook-github-test/stargazers", "contributors_url": "https://api.github.com/repos/fleetqa/webhook-github-test/contributors", "subscribers_url": "https://api.github.com/repos/fleetqa/webhook-github-test/subscribers", "subscription_url": "https://api.github.com/repos/fleetqa/webhook-github-test/subscription", "commits_url": "https://api.github.com/repos/fleetqa/webhook-github-test/commits{/sha}", "git_commits_url": "https://api.github.com/repos/fleetqa/webhook-github-test/git/commits{/sha}", "comments_url": "https://api.github.com/repos/fleetqa/webhook-github-test/comments{/number}", "issue_comment_url": "https://api.github.com/repos/fleetqa/webhook-github-test/issues/comments{/number}", "contents_url": "https://api.github.com/repos/fleetqa/webhook-github-test/contents/{+path}", "compare_url": "https://api.github.com/repos/fleetqa/webhook-github-test/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/fleetqa/webhook-github-test/merges", "archive_url": "https://api.github.com/repos/fleetqa/webhook-github-test/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/fleetqa/webhook-github-test/downloads", "issues_url": "https://api.github.com/repos/fleetqa/webhook-github-test/issues{/number}", "pulls_url": "https://api.github.com/repos/fleetqa/webhook-github-test/pulls{/number}", "milestones_url": "https://api.github.com/repos/fleetqa/webhook-github-test/milestones{/number}", "notifications_url": "https://api.github.com/repos/fleetqa/webhook-github-test/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/fleetqa/webhook-github-test/labels{/name}", "releases_url": "https://api.github.com/repos/fleetqa/webhook-github-test/releases{/id}", "deployments_url": "https://api.github.com/repos/fleetqa/webhook-github-test/deployments", "created_at": 1722511363, "updated_at": "2024-11-08T15:47:55Z", "pushed_at": 1731080885, "git_url": "git://github.com/fleetqa/webhook-github-test.git", "ssh_url": "git@github.com:fleetqa/webhook-github-test.git", "clone_url": "https://github.com/fleetqa/webhook-github-test.git", "svn_url": "https://github.com/fleetqa/webhook-github-test", "homepage": null, "size": 5, "stargazers_count": 0, "watchers_count": 0, "language": null, "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": true, "has_pages": false, "has_discussions": false, "forks_count": 0, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 0, "license": null, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "topics": [ ], "visibility": "public", "forks": 0, "open_issues": 0, "watchers": 0, "default_branch": "main", "stargazers": 0, "master_branch": "main" }, "pusher": { "name": "fleetqa", "email": "166113384+fleetqa@users.noreply.github.com" }, "sender": { "login": "fleetqa", "id": 166113384, "node_id": "U_kgDOCeawaA", "avatar_url": "https://avatars.githubusercontent.com/u/166113384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fleetqa", "html_url": "https://github.com/fleetqa", "followers_url": "https://api.github.com/users/fleetqa/followers", "following_url": "https://api.github.com/users/fleetqa/following{/other_user}", "gists_url": "https://api.github.com/users/fleetqa/gists{/gist_id}", "starred_url": "https://api.github.com/users/fleetqa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fleetqa/subscriptions", "organizations_url": "https://api.github.com/users/fleetqa/orgs", "repos_url": "https://api.github.com/users/fleetqa/repos", "events_url": "https://api.github.com/users/fleetqa/events{/privacy}", "received_events_url": "https://api.github.com/users/fleetqa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created": false, "deleted": false, "forced": false, "base_ref": null, "compare": "https://github.com/fleetqa/webhook-github-test/compare/ded1afcfdd8f...21c9d870151b", "commits": [ { "id": "21c9d870151b6da1bedc2681014c39cdf8129585", "tree_id": "048156ce21ba63d94362895ebd95ea12f4b6b24a", "distinct": true, "message": "Ensuring number of replicas is 5", "timestamp": "2024-11-08T16:48:04+01:00", "url": "https://github.com/fleetqa/webhook-github-test/commit/21c9d870151b6da1bedc2681014c39cdf8129585", "author": { "name": "fleetqa", "email": "fleet.qa.team@gmail.com", "username": "fleetqa" }, "committer": { "name": "fleetqa", "email": "fleet.qa.team@gmail.com", "username": "fleetqa" }, "added": [ ], "removed": [ ], "modified": [ "deployment.yaml" ] } ], "head_commit": { "id": "21c9d870151b6da1bedc2681014c39cdf8129585", "tree_id": "048156ce21ba63d94362895ebd95ea12f4b6b24a", "distinct": true, "message": "Ensuring number of replicas is 5", "timestamp": "2024-11-08T16:48:04+01:00", "url": "https://github.com/fleetqa/webhook-github-test/commit/21c9d870151b6da1bedc2681014c39cdf8129585", "author": { "name": "fleetqa", "email": "fleet.qa.team@gmail.com", "username": "fleetqa" }, "committer": { "name": "fleetqa", "email": "fleet.qa.team@gmail.com", "username": "fleetqa" }, "added": [ ], "removed": [ ], "modified": [ "deployment.yaml" ] } }Gitjob logs
The text was updated successfully, but these errors were encountered: