-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False diff #245
Comments
Could you please provider more concrete info?? What is detecting as a change?? Configuring provider with debug (not terraform debug) and log file like
you'll get debug messages on log_file like
Could you please test it and take a look on debug messages saying what is changing on your apply?? |
@rawmind0 there is no change in the It might be caused by the way terraform deals with data sources in 0.13 versions (see end of the debug log) : hashicorp/terraform#26100 |
@remche , i think i'm not fully understand the issue. output.log is saying that no changes in the plan, What kind of output are you using, files?? What i saw in the log is that the provider is not generating changes on the plan, but the output is adding computed fields and eventually changing the list fields order due to it's yaml content and order is not assured on marshal/unmarshal. Diff on this provider is tricky due to managing yaml content. You can have distinct yaml content (due to "random" order at list) that at the end is generating equal object. I guess that this is what terraform is showing on the output. This was working fine on tf 0.12?? |
@rawmind0 you're right, there is no changes to be applied but changes to outputs. I'm not using file for I had a look at terraform output diff, and it turns out that the |
FYI, I filtered my output to exclude some unused fields whose certificates array. That fixed it. |
Nodes array is being sorted before being saved at tfstate, https://github.com/rancher/terraform-provider-rke/blob/master/rke/structure_rke_cluster_node.go#L55 , that's why not generating diff. Ordering certificates is provided on PR #246 , that should address this issue. Could you please test it?? |
I can confirm it's fixed by PR. |
Cool. Please reopen issue if needed. |
I have false diff when reapplying with the terraform and rke provider versions.
Sanitized output.log and debug.log attached.
output.log
debug.log
The text was updated successfully, but these errors were encountered: