From d8460ebb9e351d822be5e16038aebe80141cb938 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Meusel?= <rene.meusel@rohde-schwarz.com>
Date: Fri, 6 Sep 2024 13:25:17 +0200
Subject: [PATCH] FIX: `ninja tests` fails to build for 'shared'

When building a specific target (e.g. 'tests'), the job dependency pointed
to 'libbotan-3.so.6'. This target will explicitly build just 'libbotan-3.so.6'
but fail to set up the required symlinks 'libbotan-3.so' and '.so.6.6.0'. As
a result, the linker command with `-lbotan-3` will fail to find the shared
object.
---
 src/build-data/ninja.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/build-data/ninja.in b/src/build-data/ninja.in
index e2ee02ed2c2..f010ed9f8f2 100644
--- a/src/build-data/ninja.in
+++ b/src/build-data/ninja.in
@@ -88,9 +88,9 @@ rule link_tests
 
 # Executable targets
 
-build %{cli_exe}: link_cli %{join cli_objs} | %{library_targets}
+build %{cli_exe}: link_cli %{join cli_objs} | libs
 
-build %{test_exe}: link_tests %{join test_objs} | %{library_targets}
+build %{test_exe}: link_tests %{join test_objs} | libs
 
 %{if build_fuzzers}
 
@@ -120,7 +120,7 @@ build examples: phony | %{example_bin}
 
 %{if build_bogo_shim}
 
-build botan_bogo_shim: link_cli bogo_shim_object | %{library_targets}
+build botan_bogo_shim: link_cli bogo_shim_object | libs
 
 # BoGo shim
 build %{out_dir}/bogo_shim_object: compile_exe %{bogo_shim_src}
@@ -129,7 +129,7 @@ build %{out_dir}/bogo_shim_object: compile_exe %{bogo_shim_src}
 
 %{if build_ct_selftest}
 
-build botan_ct_selftest: link_cli ct_selftest_object | %{library_targets}
+build botan_ct_selftest: link_cli ct_selftest_object | libs
 
 build %{out_dir}/ct_selftest_object: compile_exe %{ct_selftest_src}
 
@@ -208,10 +208,10 @@ build %{obj}: compile_exe %{src}
 %{for fuzzer_build_info}
 build %{obj}: compile_exe %{src}
 
-build %{exe}: link_fuzzer %{obj} | %{library_targets}
+build %{exe}: link_fuzzer %{obj} | libs
 %{endfor}
 
 %{for examples_build_info}
 build %{obj}: compile_example_exe %{src}
-build %{exe}: link_cli %{obj} | %{library_targets}
+build %{exe}: link_cli %{obj} | libs
 %{endfor}