Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nexpose::Connection#list_discovery_connections for mobile and DHCP #165

Closed
erran-r7 opened this issue Apr 28, 2015 · 2 comments
Closed

Comments

@erran-r7
Copy link
Contributor

Currently discovery connections are shaped around AWS and vSphere connections. The DiscoveryConnection class and Connection#list_discovery_connections method should be updated to only return the relevant values for each connection type.

DHCP connections over Microsoft DHCP and a directory watcher for example do not include a port value, but do include an engine ID (which no other discovery connections use today).

@gschneider-r7
Copy link
Contributor

Hmm looking into this, I think there is something fishy about the XML response currently. We're showing an engine ID for non-DHCP connections, which as you said is not used that way. This seems like it would not validate against the 1.2 API schema. Edit: The schema has been updated for the optional fields, but I feel like there would still be problems for some other clients consuming it.

@gschneider-r7
Copy link
Contributor

This is not currently possible to implement in the gem. New API endpoints should be exposed from Nexpose first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants