Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicAssetGroup#save should raise an error if the result was an error #69

Closed
erran-r7 opened this issue Jul 1, 2014 · 2 comments
Closed

Comments

@erran-r7
Copy link
Contributor

erran-r7 commented Jul 1, 2014

If data['response'] is "failure." then an APIError should be raised. I suppose this may not be the expected functionality so I've opened an issue vs. PR for discussion.

I also think that DynamicAssetGroup#save should return the group ID vs. true/false. Is there a recommended way to retrieve this ID or is the only solution gathering all asset groups and searching by name and get the ID from the new asset group summary?

@defndaines
Copy link
Contributor

For the APIError issue, make sure to communicate with Kamna or Zach about how changing this might affect existing automation.

As to the behavior around save not returning the ID, this is because DAGs in the gem are just an attempt to work around the lack of API support for DAGs. As such, the gem uses the existing protocols to create DAGs. The existing calls have a design flaw in that they do not return the ID. I believe a defect around this is already being tracked, but we may have to wait for API 2.0 support to do the right thing.

@gschneider-r7
Copy link
Contributor

Closing for now as this probably won't be addressed until new API endpoints exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants