New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future import assertions syntax for importing JSON files #40

Closed

3 tasks done

bhousel opened this issue Feb 16, 2022 · 1 comment

Closed

3 tasks done

Future import assertions syntax for importing JSON files #40

bhousel opened this issue Feb 16, 2022 · 1 comment

Contributor

bhousel commented Feb 16, 2022

see osmlab/name-suggestion-index#6014 for details, but basically:

Node is now (since v16.14+) requiring "assert" syntax when importing JSON as a module.

import fileJSON from 'file.json'  assert {type: 'json'};

So this is an issue to:

add this syntax anywhere we import a JSON file
drop support for older versions of node in package.json and the CI action
remove eslint from the test command for now 😢

bhousel closed this as completed in

f16827e

Contributor Author

bhousel commented Feb 16, 2022

Just did this today - reminder that everyone working on this project probably now needs to upgrade their node.

nvm install 16.14
nvm alias default 16.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment