Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove row_conversion.cu from CUDF JNI #13374

Closed
mythrocks opened this issue May 17, 2023 · 3 comments
Closed

[BUG] Remove row_conversion.cu from CUDF JNI #13374

mythrocks opened this issue May 17, 2023 · 3 comments
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@mythrocks
Copy link
Contributor

mythrocks commented May 17, 2023 •
edited
Loading

Depends on NVIDIA/spark-rapids-jni#1149.

CUDF JNI has a row_conversion.cu that is likely cruft, and not used anywhere else. This was used at one point from spark-rapids, but it has been replaced by the version of row_conversion.cu available in spark-rapids-jni.

Once the differences between these have been reviewed, it should be safe to remove this from CUDF JNI.
@mythrocks mythrocks added bug Something isn't working Needs Triage Need team to review and classify Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels May 17, 2023
@mythrocks
Copy link
Contributor Author

(This should probably be left till the 23.08 release.)

@mythrocks mythrocks mentioned this issue May 19, 2023
Merged
3 tasks
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment and removed Needs Triage Need team to review and classify labels Jun 7, 2023
@GregoryKimball
Copy link
Contributor

Hey @mythrocks now that the cudf repo is in 23.08, is this worth revisiting?

@ttnghia
Copy link
Contributor

ttnghia commented Dec 21, 2023

Code was removed in #14664. Close this.

@ttnghia ttnghia closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mythrocks @ttnghia @GregoryKimball