From def8be2f4f59385a6218cc6824d432459dfbc431 Mon Sep 17 00:00:00 2001
From: Sevag H <shanssian@nvidia.com>
Date: Thu, 20 Apr 2023 17:38:01 -0400
Subject: [PATCH] Avoid skbuild 0.17.2 which affected the cmake
 -DPython_LIBRARY string (#13188)

We see builds are failing in cuDF, possibly because of a missing `-DPython_LIBRARY` string in the CMake command: https://github.com/rapidsai/cudf/actions/runs/4750812902/jobs/8439338686#step:11:861

This may be a result of the scikit-build release 0.17.2: https://github.com/scikit-build/scikit-build/pull/943/files

Authors:
  - Sevag H (https://github.com/sevagh)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: https://github.com/rapidsai/cudf/pull/13188
---
 conda/environments/all_cuda-118_arch-x86_64.yaml | 2 +-
 dependencies.yaml                                | 2 +-
 python/cudf/pyproject.toml                       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/conda/environments/all_cuda-118_arch-x86_64.yaml b/conda/environments/all_cuda-118_arch-x86_64.yaml
index 911f0472432..82f09343f1e 100644
--- a/conda/environments/all_cuda-118_arch-x86_64.yaml
+++ b/conda/environments/all_cuda-118_arch-x86_64.yaml
@@ -73,7 +73,7 @@ dependencies:
 - pytorch<1.12.0
 - rmm==23.4.*
 - s3fs>=2022.3.0
-- scikit-build>=0.13.1
+- scikit-build>=0.13.1,<0.17.2
 - scipy
 - spdlog>=1.11.0,<1.12
 - sphinx
diff --git a/dependencies.yaml b/dependencies.yaml
index 3e8a6b88ca1..abaf074435c 100644
--- a/dependencies.yaml
+++ b/dependencies.yaml
@@ -238,7 +238,7 @@ dependencies:
     common:
       - output_types: [conda, requirements, pyproject]
         packages:
-          - scikit-build>=0.13.1
+          - scikit-build>=0.13.1,<0.17.2
           - rmm==23.4.*
       - output_types: conda
         packages:
diff --git a/python/cudf/pyproject.toml b/python/cudf/pyproject.toml
index 3b49c821eff..9db6c49f296 100644
--- a/python/cudf/pyproject.toml
+++ b/python/cudf/pyproject.toml
@@ -10,7 +10,7 @@ requires = [
     "protoc-wheel",
     "pyarrow==10.0.1.*",
     "rmm==23.4.*",
-    "scikit-build>=0.13.1",
+    "scikit-build>=0.13.1,<0.17.2",
     "setuptools",
     "wheel",
 ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.