From 04e4ca1a8582fa5e40e8854a3fa7b8864ce46d2c Mon Sep 17 00:00:00 2001 From: er-eis Date: Tue, 7 May 2024 15:18:39 -0400 Subject: [PATCH 1/3] Add contributing warning about circular imports --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 757eaa44510..3c394272625 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -161,6 +161,9 @@ To build all libraries and tests, with Python packages in development mode, simp ./build.sh --pydevelop libcudf libcudf_kafka cudf dask_cudf cudf_kafka custreamz ``` +- **WARNING**: Various changes to files, such as .pyx and .pyd, may cause errors such as + circular imports until you build again. + To run the C++ tests, run ```bash From 93358c36ef2b2c8ae26ca4ec86c66c4824bca247 Mon Sep 17 00:00:00 2001 From: er-eis Date: Wed, 8 May 2024 23:43:45 -0400 Subject: [PATCH 2/3] Better note message --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3c394272625..75dbfa1356d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -161,8 +161,7 @@ To build all libraries and tests, with Python packages in development mode, simp ./build.sh --pydevelop libcudf libcudf_kafka cudf dask_cudf cudf_kafka custreamz ``` -- **WARNING**: Various changes to files, such as .pyx and .pyd, may cause errors such as - circular imports until you build again. +- **Note**: if Cython files (`*.pxd`) have changed, the Python build must be rerun. To run the C++ tests, run From 46583da2b54af41bf03931899bfc62e19fee0564 Mon Sep 17 00:00:00 2001 From: er-eis Date: Sun, 19 May 2024 09:57:22 -0400 Subject: [PATCH 3/3] Clarify comment --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 75dbfa1356d..98c2ec0a22e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -161,7 +161,7 @@ To build all libraries and tests, with Python packages in development mode, simp ./build.sh --pydevelop libcudf libcudf_kafka cudf dask_cudf cudf_kafka custreamz ``` -- **Note**: if Cython files (`*.pxd`) have changed, the Python build must be rerun. +- **Note**: if Cython files (`*.pyx` or `*.pxd`) have changed, the Python build must be rerun. To run the C++ tests, run