diff --git a/CHANGELOG.md b/CHANGELOG.md index 3618b6b921..1c448866d8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ - PR #2783: Add pytest that will fail when GPU IDs in Dask cluster are not unique - PR #2785: Add in cuML-specific dev conda dependencies - PR #2778: Add README for FIL +- PR #2799: Reenable lightgbm test with lower (1%) proba accuracy - PR #2800: Align cuML's spdlog version with RMM's ## Bug Fixes diff --git a/python/cuml/test/test_fil.py b/python/cuml/test/test_fil.py index 3793ad32e4..7fcc074c5f 100644 --- a/python/cuml/test/test_fil.py +++ b/python/cuml/test/test_fil.py @@ -397,9 +397,6 @@ def test_output_args(small_classifier_and_preds): @pytest.mark.skipif(has_lightgbm() is False, reason="need to install lightgbm") def test_lightgbm(tmp_path): import lightgbm as lgb - from distutils.version import LooseVersion - if LooseVersion(lgb.__version__) >= LooseVersion('3.0.0'): - pytest.skip('lightgbm version 3 support is underway.') X, y = simulate_data(500, 10, random_state=43210, classification=True) @@ -436,4 +433,4 @@ def test_lightgbm(tmp_path): fil_proba = np.asarray(fm.predict_proba(X)) fil_proba = np.reshape(fil_proba, np.shape(gbm_proba)) - assert np.allclose(gbm_proba, fil_proba, 1e-3) + assert np.allclose(gbm_proba, fil_proba, 1e-2)