From d11c62b4a29dd32370290197516d8bd79e81b34f Mon Sep 17 00:00:00 2001 From: Levs Dolgovs Date: Fri, 4 Sep 2020 14:50:18 -0700 Subject: [PATCH 1/2] only the proba was wrong, and the error is <1% even on this few columns. Hence, worth reenabling --- python/cuml/test/test_fil.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/python/cuml/test/test_fil.py b/python/cuml/test/test_fil.py index 3793ad32e4..7fcc074c5f 100644 --- a/python/cuml/test/test_fil.py +++ b/python/cuml/test/test_fil.py @@ -397,9 +397,6 @@ def test_output_args(small_classifier_and_preds): @pytest.mark.skipif(has_lightgbm() is False, reason="need to install lightgbm") def test_lightgbm(tmp_path): import lightgbm as lgb - from distutils.version import LooseVersion - if LooseVersion(lgb.__version__) >= LooseVersion('3.0.0'): - pytest.skip('lightgbm version 3 support is underway.') X, y = simulate_data(500, 10, random_state=43210, classification=True) @@ -436,4 +433,4 @@ def test_lightgbm(tmp_path): fil_proba = np.asarray(fm.predict_proba(X)) fil_proba = np.reshape(fil_proba, np.shape(gbm_proba)) - assert np.allclose(gbm_proba, fil_proba, 1e-3) + assert np.allclose(gbm_proba, fil_proba, 1e-2) From bdb8aa5d096e6ef37252e66ca4adf9c8003bd465 Mon Sep 17 00:00:00 2001 From: Levs Dolgovs Date: Fri, 4 Sep 2020 14:58:11 -0700 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f50f960e86..6719a0a056 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ - PR #2783: Add pytest that will fail when GPU IDs in Dask cluster are not unique - PR #2785: Add in cuML-specific dev conda dependencies - PR #2778: Add README for FIL +- PR #2799: Reenable lightgbm test with lower (1%) proba accuracy ## Bug Fixes - PR #2744: Supporting larger number of classes in KNeighborsClassifier