Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should not start if module not found #110

Closed
erohmensing opened this issue Nov 1, 2019 · 8 comments
Closed

Server should not start if module not found #110

erohmensing opened this issue Nov 1, 2019 · 8 comments
Assignees
Labels
help wanted Extra attention is needed type:bug 🐛 Something isn't working

Comments

@erohmensing
Copy link
Contributor

I didn't provide the correct path, so it couldn't find any module with the name provided. In this case i think it makes sense that an exception be raised and a server not run.

rasa ❯ rasa run actions
2019-11-01 11:21:16 INFO     rasa_sdk.endpoint  - Starting action endpoint server...
2019-11-01 11:21:16 ERROR    rasa_sdk.executor  - Failed to register package 'actions'.
Traceback (most recent call last):
  File "/Users/ella/miniconda3/envs/rasa/lib/python3.7/site-packages/rasa_sdk/executor.py", line 175, in register_package
    self._import_submodules(package)
  File "/Users/ella/miniconda3/envs/rasa/lib/python3.7/site-packages/rasa_sdk/executor.py", line 160, in _import_submodules
    package = importlib.import_module(package)
  File "/Users/ella/miniconda3/envs/rasa/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'actions'
2019-11-01 11:21:16 INFO     rasa_sdk.endpoint  - Action endpoint is up and running on http ('0.0.0.0', 5055)

Perhaps raise an exception with an error message like:

Could not find a module `actions`. Did you provide the correct path to the actions file or folder via the '--actions' parameter?

Similar: #71

@erohmensing erohmensing added type:bug 🐛 Something isn't working good first issue help wanted Extra attention is needed labels Nov 1, 2019
@tarangchikhalia
Copy link

Hi, Can I take this open issue??

@erohmensing
Copy link
Contributor Author

Sure, that'd be great @tarang93ch! The relevant code for this issue will be in the rasa-sdk repo. Let me know if you need any help :)

@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Feb 3, 2020
@erohmensing
Copy link
Contributor Author

@tarang93ch would you still be interested in contributing? 🙂

@stale stale bot removed the status:stale label Feb 3, 2020
@tarangchikhalia tarangchikhalia removed their assignment Feb 11, 2020
@gitpranjal
Copy link
Contributor

gitpranjal commented Mar 6, 2020

Hi, can I take this open issue?

@erohmensing
Copy link
Contributor Author

Absolutely @gitpranjal, i'll assign it to you. Thanks!

@gitpranjal
Copy link
Contributor

@erohmensing the issue it resolved, you can close it now

@erohmensing
Copy link
Contributor Author

Amazing. Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants