Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pluggy on rasa_sdk #970

Merged
merged 9 commits into from
Apr 28, 2023
Merged

add pluggy on rasa_sdk #970

merged 9 commits into from
Apr 28, 2023

Conversation

souvikg10
Copy link
Contributor

@souvikg10 souvikg10 commented Apr 25, 2023 •
edited
Loading

Proposed changes:

  • This add pluggy into rasa_sdk
  • allows access to the app object created by sanic to add extensions to the server such as new routes, listeners, middleware as well as background tasks

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@souvikg10 souvikg10 changed the title Draft: add pluggy on rasa_sdk add pluggy on rasa_sdk Apr 25, 2023
ancalita
ancalita reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯 Left a few comments for improvement. Could you also please add a changelog entry of type feature?

pyproject.toml Show resolved Hide resolved
rasa_sdk/plugin.py Outdated Show resolved Hide resolved
rasa_sdk/plugin.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@souvikg10 souvikg10 mentioned this pull request Apr 27, 2023
Closed
4 tasks
@souvikg10 souvikg10 requested a review from ancalita April 27, 2023 15:46
ancalita
ancalita approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 💯

changelog/extensions.feature.md Outdated Show resolved Hide resolved
@souvikg10 souvikg10 merged commit 91148a1 into main Apr 28, 2023
@souvikg10 souvikg10 deleted the plugin-manager branch April 28, 2023 09:35
@xxm1668
Copy link

xxm1668 commented Oct 10, 2023

ModuleNotFoundError: No module named 'rasa_sdk_plugins'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

@tmbo tmbo Awaiting requested review from tmbo

@sanchariGr sanchariGr Awaiting requested review from sanchariGr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@souvikg10 @CLAassistant @xxm1668 @ancalita