Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin multidict version #4942

Merged
merged 4 commits into from
Dec 11, 2019
Merged

pin multidict version #4942

merged 4 commits into from
Dec 11, 2019

Conversation

amn41
Copy link
Contributor

@amn41 amn41 commented Dec 11, 2019 •
edited
Loading

Proposed changes:
multidict update broke sanic, see sanic-org/sanic#1729 (comment)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge
Copy link
Contributor

@amn41 We should also pin in the setup.py then. Also a comment, why we are pinning would be great.

@amn41 amn41 requested a review from wochinge December 11, 2019 12:35
wochinge
wochinge reviewed Dec 11, 2019
View reviewed changes
setup.py Show resolved Hide resolved
wochinge
wochinge reviewed Dec 11, 2019
View reviewed changes
changelog/4942.bugfix.rst Outdated Show resolved Hide resolved
@amn41 amn41 requested a review from wochinge December 11, 2019 12:40
wochinge
wochinge approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

changelog/4942.bugfix.rst Outdated Show resolved Hide resolved
wochinge
wochinge reviewed Dec 11, 2019
View reviewed changes
changelog/4942.bugfix.rst Outdated Show resolved Hide resolved
@amn41 @wochinge
Update changelog/4942.bugfix.rst
0666654 
Co-Authored-By: Tobias Wochinger <t.wochinger@rasa.com>
@amn41 amn41 merged commit 1619580 into master Dec 11, 2019
@amn41 amn41 deleted the pin-multidict branch December 11, 2019 14:30
@amn41 amn41 mentioned this pull request Dec 11, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All rasa commands show errors after successful installation
2 participants
@amn41 @wochinge