-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log training metrics to visualize them via tensorboard #5422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. One meta comment: Right now we are logging at an epoch level. I think the default behaviour should be that. Can we add an optional parameter which lets you switch the behaviour to logging at a minibatch level. In my experience, logging at minibatch level can help sometimes, so if it is an easy addition then we should implement it.
Just to be sure: How would you log on minibatch level? Would you have a counter that increases over time so that you see all steps in one plot? For example, if the first minibatch has 64 steps, the second minibatch would start with step 65 in the plot. |
@tabergma Just tried on the scaffold project dataset - The steps for test logger do not correspond to the steps for the train logger. For example, if |
This only happens if you set |
Yes, setting it to |
Yes, there should be some inherent corresponding steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added two minor comments. I think we should add a simple test as well which atleast checks if the folders are created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯 Thanks for adding support for this! 🚀
Proposed changes:
Related to https://github.com/RasaHQ/research/issues/56
Add option
tensorboard_log_directory
toDIETClasifier
,ResponseSelector
andTEDPolicy
.By default
tensorboard_log_directory
isNone
. If a valid directory is provided,metrics are written during training. After the model is trained you can take a look
at the training metrics in tensorboard. Execute
tensorboard --logdir <path-to-given-directory>
.We also write down a model summary (layers, input size, type) in the provided directory.
Status (please check what you already did):
black
(please check Readme for instructions)