Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude DIETClassifier from extractors in tests if no entities were trained #5646

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Exclude DIETClassifier from extractors in tests if no entities were trained #5646

merged 5 commits into from
Apr 16, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Apr 16, 2020 •
edited
Loading

Proposed changes:
DIETClassifier only counts as extractor if ENTITY_RECOGNITION is set to True

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from Ghostvv April 16, 2020 12:21
Ghostvv
Ghostvv reviewed Apr 16, 2020
View reviewed changes
rasa/nlu/test.py Outdated Show resolved Hide resolved
tabergma and others added 3 commits April 16, 2020 15:43
@tabergma @Ghostvv
Update rasa/nlu/test.py
7b45e0f 
Co-Authored-By: Vladimir Vlasov <vladimir@rasa.com>
@tabergma
add missing import
4e1b6a6
@tabergma
use local import
a013d89
@tabergma tabergma requested a review from Ghostvv April 16, 2020 14:58
@tabergma tabergma merged commit ee88904 into master Apr 16, 2020
@tabergma tabergma deleted the test-entity-extraction branch April 16, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostvv Ghostvv Ghostvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabergma @Ghostvv