Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty tokens from whitespace tokenizer #6119

Merged
merged 11 commits into from
Jul 2, 2020
Merged

Conversation

dakshvar22
Copy link
Contributor

@dakshvar22 dakshvar22 commented Jul 1, 2020

Proposed changes:

  • Since, we shifted away from re to regex, it looks like the .sub method introduces a few null unicode chars in the resultant string. These needed to be cleaned up.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested a review from tabergma July 1, 2020 17:52
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 Thanks!

tests/nlu/tokenizers/test_whitespace_tokenizer.py Outdated Show resolved Hide resolved
@dakshvar22 dakshvar22 merged commit 3823811 into 1.10.x Jul 2, 2020
@dakshvar22 dakshvar22 deleted the empty_unicode_token branch July 2, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants