Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty strings as output of whitespace tokenizer #6143

Merged
merged 7 commits into from
Jul 6, 2020
Merged

Fix empty strings as output of whitespace tokenizer #6143

merged 7 commits into from
Jul 6, 2020

Conversation

dakshvar22
Copy link
Contributor

Proposed changes:

  • If the original utterance contains just an emoji like "👍" then the output tokens should be ["👍"] and not [].

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested a review from tabergma July 6, 2020 11:10
tabergma
tabergma approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@rasabot rasabot merged commit 8f51534 into master Jul 6, 2020
@rasabot rasabot deleted the fix_empty_strings branch July 6, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakshvar22 @tabergma @rasabot