Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment exploding autoconfig #6952

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Oct 7, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from master to 2.0.x October 7, 2020 12:58
@wochinge wochinge requested a review from tmbo October 7, 2020 12:58
@wochinge wochinge added this to the 2.0 Rasa Open Source milestone Oct 7, 2020
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, lightning-fast fix 🏎️

@wochinge
Copy link
Contributor Author

wochinge commented Oct 7, 2020

force-mergable once the Windows tests here pass https://github.com/RasaHQ/rasa/runs/1220513919?check_suite_focus=true

@tmbo tmbo merged commit 60228ec into 2.0.x Oct 7, 2020
@tmbo tmbo deleted the fix-comment-exploding-autoconfig branch October 7, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a comment in the configuration before pipeline key leads to invalid config
3 participants