refactor: simplify if let #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking through lints clippy::option_if_let_else found these. Other findings are more complex so I skipped them.
EdJoPaTo
requested review from
orhun,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
=====================================
Coverage 94.3% 94.3%
=====================================
Files 60 60
Lines 14757 14760 +3
=====================================
+ Hits 13917 13920 +3
Misses 840 840 ☔ View full report in Codecov by Sentry. |
kdheepak
approved these changes
May 25, 2024
joshka
approved these changes
May 25, 2024
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
While looking through lints [`clippy::option_if_let_else`](https://rust-lang.github.io/rust-clippy/master/index.html#option_if_let_else) found these. Other findings are more complex so I skipped them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking through lints
clippy::option_if_let_elsefound these. Other findings are more complex so I skipped them.