-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): ensure render offset without selection properly #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
June 17, 2024 11:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
=======================================
+ Coverage 94.3% 94.4% +0.1%
=======================================
Files 60 62 +2
Lines 14679 14935 +256
=======================================
+ Hits 13843 14105 +262
+ Misses 836 830 -6 ☔ View full report in Codecov by Sentry. |
joshka
force-pushed
the
jm/fix-table-offset-bug
branch
from
June 17, 2024 12:12
1caed72
to
2b9464e
Compare
EdJoPaTo
changed the title
fix(table): enusre that table renders offset without selection properly
fix(table): ensure render offset without selection properly
Jun 17, 2024
EdJoPaTo
reviewed
Jun 17, 2024
EdJoPaTo
reviewed
Jun 18, 2024
EdJoPaTo
approved these changes
Jun 18, 2024
itsjunetime
pushed a commit
to itsjunetime/ratatui
that referenced
this pull request
Jun 23, 2024
joshka
added a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1179