Don't override default behaviour of methods if not explicitly overridden #14
Conversation
…clared in the type to register to catch classes that inherit from another custom class.
…cept of protected and change them to public.
|
I think we should also only match methods with the correct argument types (which would just be passing a "types" argument as an array with Type variables to GetMethod) |
There was a problem hiding this comment.
Thanks for contributing to the Godot .NET bindings.
I think we should also only match methods with the correct argument types (which would just be passing a "types" argument as an array with Type variables to GetMethod)
How about checking that the methods are the same like godot-cpp does? Pseudo-code example:
if (typeof(T).GetMethod("_Ready") != typeof(Node).GetMethod("_Ready"))
{
// ...
}I see that MethodInfo implements the != operator, but I'm not sure how it compares the methods.
The MethodInfo retrieved from built-in types (like Node) are guaranteed to be unique, because ClassDB doesn't support overloads.
src/Godot.BindingsGenerator/BindingsGenerator/BindingsGenerator.cs
Outdated
Show resolved
Hide resolved
| { | ||
| internal static FrozenDictionary<StringName, Func<nint, GodotObject>> CreateHelpers { get; private set; } | ||
|
|
||
| internal static FrozenDictionary<StringName, Action<ClassDBRegistrationContext>> RegisterVirtualOverridesHelpers { get; private set; } | ||
| internal delegate void RegisterVirtualOverrideHelper([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.NonPublicMethods)] Type type, ClassDBRegistrationContext context); |
There was a problem hiding this comment.
Doesn't this also need DynamicallyAccessedMemberTypes.PublicMethods?
src/Godot.BindingsGenerator/MethodBodies/RegisterVirtualOverrides.cs
Outdated
Show resolved
Hide resolved
src/Godot.BindingsGenerator/MethodBodies/RegisterVirtualOverrides.cs
Outdated
Show resolved
Hide resolved
src/Godot.BindingsGenerator/MethodBodies/RegisterVirtualOverrides.cs
Outdated
Show resolved
Hide resolved
I am looking into something similar. From what I found there is a "GetBaseDeclaration()" method in MethodInfo that would either return the same Instance, if it is not an override or the Info of the base. Getting the Info of the base type might do the same, not sure if either is faster. |
Co-authored-by: Raul Santos <raulsntos@gmail.com>
This fixes #13 by using reflection.