chore(backend): apply clippy suggestion #765
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#/get_first
https://rust-lang.github.io/rust-clippy/master/index.html#/no_effect_underscore_binding
These seem to break https://nightly.link/.
I am not 100% sure whether the
token
argument insocket_handler
is really unused? As far as I understand, it is, respectively it is overwritten withString::new()
and probably some remain from the token handling change, and the token is now obtained withinsocket_handler
?EDIT: Okay, at last the websocket connections pass a token to this function:
So since I am not 100% sure whether I understand the code correctly, Instead the warning is not ignored.