Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): apply clippy suggestion #765

Closed
wants to merge 1 commit into from
Closed

chore(backend): apply clippy suggestion #765

wants to merge 1 commit into from

Conversation

MichaIng
Copy link
Collaborator

@MichaIng MichaIng commented Mar 15, 2024

https://rust-lang.github.io/rust-clippy/master/index.html#/get_first
https://rust-lang.github.io/rust-clippy/master/index.html#/no_effect_underscore_binding

These seem to break https://nightly.link/.

I am not 100% sure whether the token argument in socket_handler is really unused? As far as I understand, it is, respectively it is overwritten with String::new() and probably some remain from the token handling change, and the token is now obtained within socket_handler?

EDIT: Okay, at last the websocket connections pass a token to this function:

            if let Some(token) = token {
                response = websocket(
                    req,
                    crate::socket_handlers::term_handler,
                    span,
                    token.to_string(),
                )?;

So since I am not 100% sure whether I understand the code correctly, Instead the warning is not ignored.

@MichaIng MichaIng added bug Something isn't working rust Pull requests that update Rust code labels Mar 15, 2024
@MichaIng MichaIng linked an issue Mar 15, 2024 that may be closed by this pull request
@MichaIng
Copy link
Collaborator Author

@ravenclaw900 I injected this commit here: #758
Still not sure about the unused _token, but it bringts us forward to have CI green, and the other change is trivial.

@MichaIng MichaIng closed this Jun 13, 2024
@MichaIng MichaIng deleted the fix/clippy branch June 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raspberry Pi 5 | Stable release fails with segmentation fault
1 participant