Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove universal api #4

Merged
merged 5 commits into from
Oct 14, 2019
Merged

feat: remove universal api #4

merged 5 commits into from
Oct 14, 2019

Conversation

balloonzzq
Copy link
Contributor

No description provided.

return {
isWeb: true
};
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种可以拿掉了。。。直接从 web 里引

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animation 暂时引不了

jest.mock('universal-env', () => {
return {
isWeex: false,
isWeb: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

isWeex: true,
isWeb: false
};
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

return {
isWeex: true,
isWeb: false
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SoloJiang SoloJiang merged commit 8806f61 into master Oct 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-remove-universal-api branch October 14, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants