feat: 增加 isQuickApp 的env变量 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat-quickapp-env
SoloJiang
approved these changes
Mar 11, 2020
…feat-quickapp-env
|
callNative 是快应用判断的唯一条件 |
wssgcg1213
reviewed
Mar 11, 2020
packages/env/README-zh_CN.md
Outdated
| | 微信小程序 | ✘ | ✔️ | ✘ | ✘ | ✘ | ✘ | | ||
| | 微信小程序 WebView | ✘ | ✔️ | ✘ | ✔️ | ✘ | ✘ | | ||
| | 快应用 | ✘ | ✘ | ✔️ | ✘ | ✘ | ✘ | | ||
| | 快应用 Webview | ✘ | ✘ | ✘ | ✔️ | ✘ | ✘ | |
wssgcg1213
approved these changes
Mar 11, 2020
yacheng
reviewed
Mar 11, 2020
packages/env/src/index.ts
Outdated
| @@ -15,3 +16,4 @@ export const isMiniApp = !isUndef(typeof my) && my !== null && !isUndef(typeof m | |||
| // In wechat mini program, wx.login is a function | |||
| // In wechat mini propgram webview, there is no wx.login, but exist wx.miniProgram | |||
| export const isWeChatMiniProgram = !isUndef(typeof wx) && wx !== null && (!isUndef(typeof wx.login) || !isUndef(typeof wx.miniProgram)); | |||
| export const isQuickApp = !isUndef(typeof global) && global !== null && (!isUndef(typeof global.callNative)) && !isWeex; | |||
There was a problem hiding this comment.
通过 callNative 判断并不带有端上特征，是否加上快应用业务上的特征会更准确，比如 useragent 的 packageName
There was a problem hiding this comment.
通过 callNative 判断并不带有端上特征，是否加上快应用业务上的特征会更准确，比如 useragent 的 packageName
目前快应用容器内的全局环境只有global，内置属性中只有callNative能拿来区分其他端。例如userAgent类的判断在快应用的web组件内部才能通过window拿到。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.