fix(tests): fix deadlock for non-race tests

ray-xu-deltatre · Jul 14, 2018 · 256c2c8 · 256c2c8
1 parent 56c79b2
commit 256c2c8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/client/service_test.go b/client/service_test.go
@@ -55,12 +55,12 @@ func TestServiceManager_removeServiceMonitor(t *testing.T) {
 	mgr.commandCompleteChan <- cmd
 	var timeout = time.After(channelTimeout)
 	for {
-		mgr.processMap.Lock()
-		defer mgr.processMap.Unlock()
 
 		select {
 		case <-time.After(10 * time.Millisecond):
+			mgr.processMap.Lock()
 			if len(mgr.processMap.processes) == 0 {
+				mgr.processMap.Unlock()
 				return
 			}
 		case <-timeout: