Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Power rankings take week as optional argument. #31

Open
dtcarls opened this issue Aug 18, 2017 · 2 comments · May be fixed by #32
Open

Request: Power rankings take week as optional argument. #31

dtcarls opened this issue Aug 18, 2017 · 2 comments · May be fixed by #32

Comments

@dtcarls
Copy link

dtcarls commented Aug 18, 2017

Request: Power rankings take week as optional argument.
Assume current week like with scoreboard if no week provided.
@dtcarls
Copy link
Author

dtcarls commented Aug 22, 2017

Not really sure how to implement it because of my limited python knowledge, but it appears current week is stored in 'scoreboard'->'scoringPeriodId' within the json data

@dtcarls dtcarls linked a pull request Aug 23, 2017 that will close this issue
Open
@dtcarls
Copy link
Author

dtcarls commented Aug 25, 2017

Tested as follows.

$ python3 setup.py install
$ python3
>>> from espnff import League
>>> league_id = 164483
>>> year = 2016
>>> league = League(league_id, year)
>>> league.get_current_week()
18
>>> year = 2017
>>> league = League(league_id, year)
>>> league.get_current_week()
1

@dtcarls dtcarls mentioned this issue Sep 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made power rankings get current week by default and week parameter optional
1 participant
@dtcarls