Skip to content

Commit

Permalink
v9.2.5-alpha.5 LH config + about page (#16)
Browse files Browse the repository at this point in the history
* fix: Lighthouse plugin config and about page file links

  1. Lighthouse plugin config

    - set `fail_deploy_on_score_thresholds = "true”` in `[plugins.inputs]`
      to get some of the old behavior back. mastodon discussion:
      https://mastodon.social/@rdela/112208080966164909

    - PR 588 netlify/netlify-plugin-lighthouse#588
      Looks like a bunch of the config options and behavior changed
      and then netlify disabled issues

    - netlify-plugin-lighthouse is now in maintenance(-only) mode
      https://github.com/netlify/netlify-plugin-lighthouse/blob/main/CONTRIBUTING.md
      https://fosstodon.org/@eleventy/112208087737676821

    - explain lowering of seo failure threshold due to `x-robots-tag: noindex`
      header set on deploy previews

  2. about page file links

    - these worked in README but needed full URLs to trunk branch for the site
  • Loading branch information
rdela authored Apr 3, 2024
1 parent 61ee887 commit 5172fb3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions _data/metadata.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let data = {
title: "eleventeen v9.2.4-alpha.5",
title: "eleventeen v9.2.5-alpha.5",
url: "https://eleventeen.blog",
language: "en",
description: "Rainbow Eleventy blog",
Expand All @@ -9,7 +9,7 @@ let data = {
url: "https://example.org",
},
mono: false,
eleventeen: "v9.2.4-alpha.5",
eleventeen: "v9.2.5-alpha.5",
};

export default data;
2 changes: 1 addition & 1 deletion content/about/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Eleventy Base Blog is:
In addition to Base Blog’s killer features and Eleventy 3’s bundler-free [ESM](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) support, eleventeen sports a novel new visual experience we call [Rainbow Mode™](https://github.com/rdela/eleventeen/pull/1), powered by [Chromagen](https://github.com/famebot/chromagen), the color scheme generator we publish under the [Famebot](https://github.com/famebot) organization. Our homegrown Rainbow Mode is wholly distinct from and not to be confused with Emacs [rainbow-mode](https://elpa.gnu.org/packages/rainbow-mode.html), which “sets background color to strings that match color
names.” We posit a third color scheme preference in addition to light and dark “modes,” rainbow.

Here in the world of eleventeen, rainbow is the default. But we acknowledge not all sites are a match for Rainbow Mode, and still want those sites to enjoy the rest of what eleventeen has to offer, so [v9.2.3-alpha.5](https://github.com/rdela/eleventeen/releases/tag/v9.2.3-alpha.5), adds a `mono` option to [`_data/metadata.js`](_data/metadata.js) in [PR #13](https://github.com/rdela/eleventeen/pull/13) that will disable Rainbow Mode if you set it to `true`. `mono` is `false` by default, on purpose, because it beats making people set an option called `rainbow` to `false` and might make the current {% raw %}`{%- if not metadata.mono %}`{% endraw %} template logic in [`_includes/layouts/base.njk`](_includes/layouts/base.njk) a little more resilient.
Here in the world of eleventeen, rainbow is the default. But we acknowledge not all sites are a match for Rainbow Mode, and still want those sites to enjoy the rest of what eleventeen has to offer, so [v9.2.3-alpha.5](https://github.com/rdela/eleventeen/releases/tag/v9.2.3-alpha.5), adds a `mono` option to [`_data/metadata.js`](https://github.com/rdela/eleventeen/blob/trunk/_data/metadata.js) in [PR #13](https://github.com/rdela/eleventeen/pull/13) that will disable Rainbow Mode if you set it to `true`. `mono` is `false` by default, on purpose, because it beats making people set an option called `rainbow` to `false`, plus it might make the current {% raw %}`{%- if not metadata.mono %}`{% endraw %} template logic in [`_includes/layouts/base.njk`](https://github.com/rdela/eleventeen/blob/trunk/_includes/layouts/base.njk) a little more resilient.

You can see mono enabled at [mono.eleventeen.blog](https://mono.eleventeen.blog). Try toggling light and dark mode using devtools, there are links to how at the bottom to [chromagen.io](https://chromagen.io/). The rainbow eleventeen demo still lives at [eleventeen.blog](https://eleventeen.blog) <span role="img" aria-label="">🌈📓</span>

Expand Down
8 changes: 5 additions & 3 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@

package = "@netlify/plugin-lighthouse"

[plugins.inputs]
fail_deploy_on_score_thresholds = "true"
output_path = "reports/lighthouse/index.html"

# optional, fails build when a category is below a threshold
# deploy previews score 92 on seo due to `x-robots-tag: noindex` header
[plugins.inputs.thresholds]
performance = 1.0
accessibility = 1.0
best-practices = 1.0
seo = 0.9

[plugins.inputs]
output_path = "reports/lighthouse/index.html"
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eleventeen",
"version": "9.2.4-alpha.5",
"version": "9.2.5-alpha.5",
"description": "A starter repository for a blog web site using the Eleventy site generator.",
"type": "module",
"scripts": {
Expand Down

0 comments on commit 5172fb3

Please sign in to comment.