fix(Slider): adds initial content so Value shows on load #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwehrman
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Passed. |
arwehrman
force-pushed
the
fix/slider-text-on-intial-load
branch
from
bdcbf04 to
dce82d8
Compare
|
Test Execution Passed. |
ImCoolNowRight
approved these changes
Jan 3, 2024
erautenberg
approved these changes
Jan 3, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Jan 10, 2024
# [@lightningjs/ui-components-v2.19.6](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.19.5...@lightningjs/ui-components-v2.19.6) (2024-01-10) ### Bug Fixes * **CardTitle:** updating Input and CardTitle styles to resemble mosaic ([#454](#454)) ([3f9ab40](3f9ab40)) * **Import:** standardize how components are imported ([#455](#455)) ([5f7ce24](5f7ce24)) * Move construct super to fix memory leak when using multiple withThemeStyles ([#456](#456)) ([e983f17](e983f17)) * **Slider:** adds intial content so Value shows on load ([#451](#451)) ([5e00f9b](5e00f9b)) * **Tile:** update conditions to show/hide gradient ([#457](#457)) ([31514cd](31514cd)) * **Tooltip:** adds updateBackground to _update ([#434](#434)) ([63ee073](63ee073))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.19.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR adds 'Value: 0' to
Text.contentso there is a value showing on initial load of the storyReferences
LUI-1305
Testing
cd into branch
go to signalSlider story
Value: 0 should appear under the Slider component and should update when clicking on left and right arrows
Automation
Checklist