fix(Tile): update conditions to show/hide gradient #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImCoolNowRight
requested review from
erautenberg,
joshhowenstine,
anthony9187,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
ImCoolNowRight
force-pushed
the
fix/LUI-1276
branch
from
3306f0f to
eaf21c9
Compare
|
Test Execution Passed. |
1 similar comment
|
Test Execution Passed. |
|
Test Execution Passed. |
erautenberg
approved these changes
Jan 10, 2024
|
Test Execution Passed. |
anthony9187
approved these changes
Jan 10, 2024
|
Test Execution Passed. |
1 similar comment
|
Test Execution Passed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Jan 10, 2024
# [@lightningjs/ui-components-v2.19.6](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.19.5...@lightningjs/ui-components-v2.19.6) (2024-01-10) ### Bug Fixes * **CardTitle:** updating Input and CardTitle styles to resemble mosaic ([#454](#454)) ([3f9ab40](3f9ab40)) * **Import:** standardize how components are imported ([#455](#455)) ([5f7ce24](5f7ce24)) * Move construct super to fix memory leak when using multiple withThemeStyles ([#456](#456)) ([e983f17](e983f17)) * **Slider:** adds intial content so Value shows on load ([#451](#451)) ([5e00f9b](5e00f9b)) * **Tile:** update conditions to show/hide gradient ([#457](#457)) ([31514cd](31514cd)) * **Tooltip:** adds updateBackground to _update ([#434](#434)) ([63ee073](63ee073))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.19.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates under what conditions the gradient is shown/hidden on Tile.
References
LUI-1276
Testing
Ensure that the gradient shows when any of the below are visible on the Tile and hidden when none are visible:
Automation
This does update the visibility of the gradient, so it may require updates to the Tile tests.
Checklist