Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Keyboard): setting selectedIndex when creating rows #462

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix(Keyboard): setting selectedIndex when creating rows #462

merged 1 commit into from
Feb 2, 2024

Conversation

slhay28
Copy link
Contributor

@slhay28 slhay28 commented Jan 30, 2024

Description

setting the selectedIndex for the Row when creating a new keyboard on toggle

References

LUI-1320

Testing

  • migrate to a keyboard that has multiple formats (example: keyboard-qwerty)
  • click one of the keys that toggle a keyboard change (such as symbols, shift etc)
  • notice how the focus stays on that key

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight merged commit 0f7b6c3 into develop Feb 2, 2024
9 checks passed
@ImCoolNowRight ImCoolNowRight deleted the fix/Keyboard-change-focus branch February 2, 2024 15:21
svc-lightning-ui-components pushed a commit that referenced this pull request Feb 6, 2024
@semantic-release-bot
chore(release): 2.20.1 [skip ci]
cc31852 
# [@lightningjs/ui-components-v2.20.1](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.0...@lightningjs/ui-components-v2.20.1) (2024-02-06)

### Bug Fixes

* **Keyboard:** setting selectedIndex when creating rows ([#462](#462)) ([0f7b6c3](0f7b6c3))
* **TabBar:** add missing getters/setters from LUI 4 ([#460](#460)) ([fc5a142](fc5a142))
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImCoolNowRight ImCoolNowRight ImCoolNowRight approved these changes

@joshhowenstine joshhowenstine joshhowenstine approved these changes

@erautenberg erautenberg Awaiting requested review from erautenberg erautenberg is a code owner

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 is a code owner

@THoj13 THoj13 Awaiting requested review from THoj13

@arwehrman arwehrman Awaiting requested review from arwehrman

@jazzyw jazzyw Awaiting requested review from jazzyw

@soumyaloka soumyaloka Awaiting requested review from soumyaloka soumyaloka is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slhay28 @svc-lightning-ui-components @joshhowenstine @ImCoolNowRight