fix(Keyboard): currentKeyboard not undefined check before calling functions on it #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slhay28
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw and
soumyaloka
as code owners
erautenberg
approved these changes
Feb 19, 2024
|
Test Execution Failed. |
ImCoolNowRight
approved these changes
Feb 20, 2024
…g capitalize on it
ImCoolNowRight
force-pushed
the
fix/Keyboard-render-race
branch
from
8504172 to
cfd622d
Compare
|
Test Execution Failed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Feb 23, 2024
# [@lightningjs/ui-components-v2.20.2](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.1...@lightningjs/ui-components-v2.20.2) (2024-02-23) ### Bug Fixes * Add marquee property to title in Card ([#469](#469)) ([ae187ec](ae187ec)) * **Keyboard:** adding a check if currentFormat is valid before calling capitalize on it ([#474](#474)) ([76c4e49](76c4e49)) * **Keyboard:** make row render when key is empty ([#472](#472)) ([334bf88](334bf88)) * **MetadataBase:** fix layout order ([#471](#471)) ([b77db31](b77db31)) * **Title:** do not render title textbox unless there is a title present ([#475](#475)) ([81549db](81549db)) * **Toggle:** fillInverseDisabled typo in styles ([#473](#473)) ([4ab5c0f](4ab5c0f))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.20.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The getFocused method called a capitalization function on the currentKeyboard which in some cases hadn't been set yet. This fix checks to see if there is a currentKeyboard before calling the capitalize function.
References
LUI-1340
Testing
Have been unable to reproduce in storybook or playground.
I tested this by...
Automation
Checklist