fix: small optimization to add extra gaurd to updatePropDefaults #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhowenstine
requested review from
erautenberg,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Failed. |
1 similar comment
|
Test Execution Failed. |
ImCoolNowRight
approved these changes
Mar 6, 2024
slhay28
approved these changes
Mar 6, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Mar 7, 2024
# [@lightningjs/ui-components-v2.20.4](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.3...@lightningjs/ui-components-v2.20.4) (2024-03-07) ### Bug Fixes * remove circular dependency warnings when generating bundled ts file ([#481](#481)) ([f981f8b](f981f8b)) * small optimization to add extra gaurd to updatePropDefaults ([#482](#482)) ([589b9e1](589b9e1))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.20.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small optimization to withThemeStyles to make sure updatePropDefaults does not run if the styleManager does not have any props
Testing
Everything should work ask previously expected. The entire _updatePropDefaults method in withThemeStyles should not run each time a component is created unless props are defined in the theme.
Automation
NA
Checklist